[foreign-jextract] RFR: 8252047: jextract generates uncompilable code with --source option [v2]

Athijegannathan Sundararajan sundar at openjdk.java.net
Thu Aug 20 12:29:52 UTC 2020


On Wed, 19 Aug 2020 21:08:11 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Athijegannathan Sundararajan has updated the pull request incrementally with one additional commit since the last
>> revision:
>>   Access LIBRARIES field without fully qualified name.
>
> src/jdk.incubator.jextract/share/classes/jdk/internal/jextract/impl/OutputFactory.java line 395:
> 
>> 394:         }
>> 395:         if (layout.equals(CSupport.C_LONGDOUBLE)) {
>> 396:             warn("skipping " + fieldName + " because of long double usage");
> 
> perhaps we could have a method which tests for equality with C_LONGDOUBLE and the same method is called both here and
> from the useLongDouble function above?

I'lll refactor that as a separate method.

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/286


More information about the panama-dev mailing list