[foreign-jextract] RFR: 8252121: jextract generated code fails with ABI for typedefed array type parameters

Maurizio Cimadamore mcimadamore at openjdk.java.net
Thu Aug 20 18:09:49 UTC 2020


On Thu, 20 Aug 2020 17:47:33 GMT, Athijegannathan Sundararajan <sundar at openjdk.org> wrote:

> TypeMaker now special cases typedef'ed arrays for argument types for functions.

I believe there are some recursion issues with multiple typedefs (we need also a test for that)

src/jdk.incubator.jextract/share/classes/jdk/internal/jextract/impl/TypeMaker.java line 240:

> 239:             if (t.kind() == Delegated.Kind.TYPEDEF && t.type() instanceof Type.Array) {
> 240:                 return visitArray((Type.Array)t.type(), aVoid);
> 241:             }

shouldn't we just recurse on the type() field? what if it's a typedef of a typedef of a typedef....

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/287


More information about the panama-dev mailing list