[foreign-memaccess] Integrated: Unsafe ParallelSum test is broken
Maurizio Cimadamore
mcimadamore at openjdk.java.net
Mon Aug 24 11:04:51 UTC 2020
On Mon, 24 Aug 2020 09:59:16 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:
> The numbers for the unsafe parallel sum tests are artificially low; after some debugging I realized that the test was
> not summing up all components. I then plugged in the unsafe fork join action into our existing memory segment
> spliterator test, and verified that indeed that fork join action was violating all assertions.
> I then fixed all the issues, verified that assertions were satisfied and then plugged the fixed action back into the
> microbenchmark.
> Unsurprisingly, the perf numbers of the unsafe part are now in sync with those obtained from the segment counterpart.
This pull request has now been integrated.
Changeset: 81c74633
Author: Maurizio Cimadamore <mcimadamore at openjdk.org>
URL: https://git.openjdk.java.net/panama-foreign/commit/81c74633
Stats: 9 lines in 1 file changed: 0 ins; 4 del; 5 mod
Unsafe ParallelSum test is broken
Reviewed-by: jvernee, sundar
-------------
PR: https://git.openjdk.java.net/panama-foreign/pull/288
More information about the panama-dev
mailing list