[foreign-abi] RFR 8237360: Add tests that test binding recipe generation directly

Maurizio Cimadamore maurizio.cimadamore at oracle.com
Tue Feb 4 12:24:59 UTC 2020


Looks nice! I suggest replacing the int with the various Binding tags 
with an enum; this helps with code readability, but I think would also 
help whenever you are using tag() inside a string.

Maurizio

On 03/02/2020 12:30, Jorn Vernee wrote:
> Hi,
>
> Please review the following patch that adds tests for the binding 
> recipe generators. These tests are more or less transcribed from the 
> old CallingSequenceBuilder tests on the foreign branch.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8237360
> Webrev: 
> http://cr.openjdk.java.net/~jvernee/panama/webrevs/8237360/webrev.00/
>
> This also helped me find a couple of bugs in the Aarch64 CallArranger 
> that I introduced in an earlier patch, which I've fixed.
>
> Thanks,
> Jorn
>


More information about the panama-dev mailing list