RFR: 8237360: Add tests that test binding recipe generation directly
Maurizio Cimadamore
mcimadamore at openjdk.java.net
Tue Feb 4 15:01:02 UTC 2020
On Tue, 4 Feb 2020 14:08:03 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:
> Continuation of: _https://mail.openjdk.java.net/pipermail/panama-dev/2020-February/007417.html_
>
>> Hi,
>>
>> Please review the following patch that adds tests for the binding recipe
>> generators. These tests are more or less transcribed from the old
>> CallingSequenceBuilder tests on the foreign branch.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8237360
>> Webrev:
>> http://cr.openjdk.java.net/~jvernee/panama/webrevs/8237360/webrev.00/
>>
>> This also helped me find a couple of bugs in the Aarch64 CallArranger
>> that I introduced in an earlier patch, which I've fixed.
>>
>> Thanks,
>> Jorn
Looks good!
>
> Yes, this is a good idea, the tag does not need to be a simple int
> (anymore).
>
> I'd like to add that to the Binding cleanup patch instead though (this
> also changes some of the names), OK?
Sounds good.
-------------
Marked as reviewed by mcimadamore (Reviewer).
PR: https://git.openjdk.java.net/panama-foreign/pull/1
More information about the panama-dev
mailing list