[Rev 01] RFR: 8237359: Clean up Binding
Jorn Vernee
jvernee at openjdk.java.net
Mon Feb 10 16:27:27 UTC 2020
> Continuation of: https://mail.openjdk.java.net/pipermail/panama-dev/2020-February/007417.html
>
>> Hi,
>>
>> Please review the following patch that does a few cleanups of the
>> Binding class implementation:
>> - Adds javadoc
>> - Uses static factory methods instead of raw constructors. This allows
>> returning singletons for some of the operators for instance.
>> - Constructing a COPY_BUFFER binding now requires a MemoryLayout,
>> instead of a separate size & alignment. This was easier given the use-cases.
>> - Binding.AllocateBuffer renamed to Binding.Allocate (since we already
>> had Copy as well).
>> - BoxAddress renamed to ConvertAddress, as a more general name to
>> describe the boxing & unboxing that can occur. Suggested by Maurizio.
>>
>> Webrev:
>> http://cr.openjdk.java.net/~jvernee/panama/webrevs/cleanup_bindings/webrev.00/
>> Bugs: https://bugs.openjdk.java.net/browse/JDK-8237359,
>> https://bugs.openjdk.java.net/browse/JDK-8238227,
>> https://bugs.openjdk.java.net/browse/JDK-8238235
>>
>> This patch take care of several smaller issues all at once. It applies
>> on top of the JDK-8237360 patch.
>>
>> Thanks,
>> Jorn
The pull request has been updated with 1 additional commit.
-------------
Added commits:
- 4bf3e593: Address review comments:
Changes:
- all: https://git.openjdk.java.net/panama-foreign/pull/12/files
- new: https://git.openjdk.java.net/panama-foreign/pull/12/files/40562472..4bf3e593
Webrevs:
- full: https://webrevs.openjdk.java.net/panama-foreign/12/webrev.01
- incr: https://webrevs.openjdk.java.net/panama-foreign/12/webrev.00-01
Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
Patch: https://git.openjdk.java.net/panama-foreign/pull/12.diff
Fetch: git fetch https://git.openjdk.java.net/panama-foreign pull/12/head:pull/12
PR: https://git.openjdk.java.net/panama-foreign/pull/12
More information about the panama-dev
mailing list