RFR: 8238837: AArch64: TestUpcall failures after JDK-8237358

Jorn Vernee jvernee at openjdk.java.net
Tue Feb 11 11:30:21 UTC 2020


On Tue, 11 Feb 2020 11:21:26 GMT, Nick Gasson <ngasson at openjdk.org> wrote:

> The binding interpreter changes in JDK-8237358 cause a failure on
> AArch64 when a struct parameter whose size is not a multiple of 8 is
> spilled to the stack. Because the generated bindings dereference the
> struct as a series of Java longs, the final long read will read past the
> end of the MemorySegment.
> 
> Fix by dereferencing using a type that is appropriate for the size to
> copy. E.g. long for 8 bytes, int for 4 bytes, etc.
> 
> Tested jdk_foreign on aarch64 and x86_64.

Marked as reviewed by jvernee (Committer).

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/13


More information about the panama-dev mailing list