[foreign-abi] RFR: 8239345: need an enum for standard C types and a way to get a memory layout for those C types

Jorn Vernee jvernee at openjdk.java.net
Wed Feb 19 18:23:24 UTC 2020


On Wed, 19 Feb 2020 17:47:51 GMT, Athijegannathan Sundararajan <sundar at openjdk.org> wrote:

> SystemABI.Type enum added and ABI_CLASS attribute of layout removed (inferred from Type instead)

Looks good!

src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/MemoryLayouts.java line 145:

> 144: 
> 145: /**
> 146:      * The {@code _Bool} native type.

Don't think this was intentional?
Suggestion:

    /**

-------------

Marked as reviewed by jvernee (Committer).

PR: https://git.openjdk.java.net/panama-foreign/pull/24


More information about the panama-dev mailing list