[foreign-jextract] RFR: 8239491: Missing CursorKind and TypeKind constants for LLVM 9
Maurizio Cimadamore
mcimadamore at openjdk.java.net
Mon Feb 24 21:07:08 UTC 2020
On Mon, 24 Feb 2020 18:36:53 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:
> Adds some missing LLVM9 CursorKind and TypeKind enum constants. Whenever these kinds are encountered during parsing and exception is throw, even if the value is otherwise ignored.
>
> - Also renames ParamDecl to ParmDecl to keep parity with [`Index.h`](https://github.com/llvm/llvm-project/blob/master/clang/include/clang-c/Index.h#L1765)
> - Also removes the `FirstExtraDecl` and `LastExtraDecl` constants, since these are just markers used in C, and we don't need them in Java (actually, they might cause problems by overwriting the actual values in the lookup map).
Looks good - I wonder how to you trigger ParmDecl? It seems like what we had was working with function parameters?
-------------
Marked as reviewed by mcimadamore (Committer).
PR: https://git.openjdk.java.net/panama-foreign/pull/28
More information about the panama-dev
mailing list