[foreign-jextract] [Rev 01] RFR: 8239809: Need API to access attributes

[Henry Jen]

On Tue, 25 Feb 2020 18:15:55 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> The pull request has been updated with 1 additional commit.
> 
> Overall looks good, but let's try to minimize the API impact. Declaration attributes are, after all, an escape hatch, and we should not publicize them too much in the various declaration factories.
> 
> This also reminds me that we never sorted out lack of equals/hashcode in Declaration/Type implementation classes. We should address that (and make these method take into account attributes too). But it's probably preferrable to do this in a separate pull request.

> 
> This also reminds me that we never sorted out lack of equals/hashcode in Declaration/Type implementation classes. We should address that (and make these method take into account attributes too). But it's probably preferrable to do this in a separate pull request.

I actually had implemented a matcher for Declaration/Type using Visitor, which is probably more flexible.

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/33