[foreign-jextract] RFR: 8240181: jextract does not generate constants for anonymous enum fields

Maurizio Cimadamore mcimadamore at openjdk.java.net
Thu Feb 27 17:32:23 UTC 2020


On Thu, 27 Feb 2020 15:08:01 GMT, Athijegannathan Sundararajan <sundar at openjdk.org> wrote:

> anonymous enums were filtered by TreeMaker.

Looks good - just a question about testing methodology.

test/jdk/tools/jextract/JextractToolProviderTest.java line 43:

> 42:  */
> 43: public class JextractToolProviderTest extends JextractToolRunner {
> 44:     @Test

One comment on testing - note that we also have a separate framework to just test the API (w/o jextract). After all, this is not, strictly speaking a jextract bug, but a bug in the declaration API parsing, so perhaps a more direct test would be preferrable?

-------------



PR: https://git.openjdk.java.net/panama-foreign/pull/35


More information about the panama-dev mailing list