[foreign-memaccess] RFR 8219852: Create a set of standard benchmarks

Maurizio Cimadamore maurizio.cimadamore at oracle.com
Thu Jan 9 15:37:07 UTC 2020


Looks good!

Maurizio

On 09/01/2020 15:21, Jorn Vernee wrote:
> On 09/01/2020 15:58, Maurizio Cimadamore wrote:
>> Looks good and works on my machine.
>>
>> I'd suggest a couple of changes:
>>
>> * benchmarks are java/foreign, shouldn't they be 
>> jdk.incubator.foreign, for consistency with module/package name?
> Good point. (I copied what I had from a while back before we switched 
> to the incubator module)
>>
>> * Hoisting seems general as a name - I think what you want to test 
>> here is hoisting when segment is non-final, non-static variable - I 
>> have a similar benchmark for true constant segments that I'd like to 
>> upload, so we need slightly more precise names :-)
>
> Could do LoopOverNonConstant?
>
> Updated webrev: 
> http://cr.openjdk.java.net/~jvernee/panama/webrevs/8219852/webrev.01/
>
> Jorn
>
>>
>> Cheers
>> Maurizio
>>
>> On 09/01/2020 14:32, Jorn Vernee wrote:
>>> make test TEST="micro:java.foreign" MICRO="VM_OPTIONS=--add-modules 
>>> jdk.incubator.foreign"


More information about the panama-dev mailing list