[foreign-abi] RFR: Fix javadoc issues in foreign-abi

Jorn Vernee jvernee at openjdk.java.net
Thu Jul 2 18:04:35 UTC 2020


On Thu, 2 Jul 2020 17:44:00 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

> This patch addresses several issues with foreign-abi javadoc, which are preventing javadoc to complete succesfully on
> the jdk.incubator.foreign package.
> I added the various bits of missing documentation and fixed all relevant warnings - the comments will likely need a
> later pass, but at least now javadoc can be built w/o issues.

Marked as reviewed by jvernee (Committer).

src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/CSupport.java line 546:

> 545:             INTEGER,
> 546:             /** Classification constant for machine integral values */
> 547:             VECTOR,

Seems like a typo
Suggestion:

            /** Classification constant for machine floating point values */

src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/FunctionDescriptor.java line 47:

> 46:     /**
> 47:      * The name of the function descriptor attribute (see {@link #attributes()} used to mark variadic parameters.
> The 48:      * attribute value must be a boolean.

Suggestion:

     * The name of the function descriptor attribute (see {@link #attributes()} used to mark trivial functions. The

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/230


More information about the panama-dev mailing list