[foreign-jextract] RFR: 8248415: Create VarHandles for pointer fields through the MemoryHandles API [v3]
Filip Krakowski
github.com+7255767+krakowski at openjdk.java.net
Mon Jul 6 19:31:48 UTC 2020
On Thu, 2 Jul 2020 15:28:05 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:
>> One of the tests is failing, and it looks like there's a bug. I've left an inline comment about that.
>
> There should also be a test added for this use-case. You can use e.g.
> https://github.com/openjdk/panama-foreign/blob/foreign-jextract/test/jdk/tools/jextract/Test8240811.java as an example.
> The test is just running jextract using the methods in the JextractToolRunner super class, and is then using reflection
> to verify that all the required elements are generated.
> You can also check out doc/testing.{md|html} for pointers on how to run tests. Generally it's as easy as configuring
> with `--with-jtreg=path/to/jtreg` and then running `make run-test-jdk_jextract` (assuming that you also have the
> libclang dependency set up). You can get a pre-built jtreg bundle (our testing tool) from adopt at:
> https://ci.adoptopenjdk.net/view/Dependencies/job/jtreg/ (be sure to use version 5.1), that's also the one I'm using.
Sorry for getting back to this so late, @JornVernee ! I've been pretty busy the last few days. I reconfigured my local
build using your instructions, added a test covering this use-case, and ran jtreg. I am amazed how easy it is to test
the JDK.
-------------
PR: https://git.openjdk.java.net/panama-foreign/pull/216
More information about the panama-dev
mailing list