[foreign-jextract] RFR: 8248415: Create VarHandles for pointer fields through the MemoryHandles API [v3]

Jorn Vernee jvernee at openjdk.java.net
Tue Jul 7 12:20:39 UTC 2020


On Mon, 6 Jul 2020 19:31:48 GMT, Filip Krakowski <github.com+7255767+krakowski at openjdk.org> wrote:

>> This PR creates an adapted
>> [`VarHandle`](https://github.com/openjdk/panama-foreign/blob/foreign-jextract/src/java.base/share/classes/java/lang/invoke/VarHandle.java)
>> usable with
>> [`MemoryAddress`](https://github.com/openjdk/panama-foreign/blob/foreign-jextract/src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/MemoryAddress.java)
>> carriers for pointer fields. It uses
>> [`MemoryHandles#asAddressVarHandle`](https://github.com/openjdk/panama-foreign/blob/foreign-jextract/src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/MemoryHandles.java#L334-L350)
>> and a previously created `long` VarHandle to do so.
>
> Filip Krakowski has updated the pull request with a new target base due to a merge or a rebase. The pull request now
> contains three commits:
>  - Add test for pointer typed fields in structs
>  - Fix some carrier entries within carrier map
>  - 8248415: Create VarHandles for pointer fields through the MemoryHandles API

Looks good

-------------

Marked as reviewed by jvernee (Committer).

PR: https://git.openjdk.java.net/panama-foreign/pull/216


More information about the panama-dev mailing list