[foreign-jextract] RFR: 8249300: jextract does not handle empty parameter list of a function pointer parameters

Henry Jen henryjen at openjdk.java.net
Tue Jul 14 18:35:03 UTC 2020


On Tue, 14 Jul 2020 17:52:30 GMT, Athijegannathan Sundararajan <sundar at openjdk.org> wrote:

> Array type parameter in function callback is handled properly

Change looks good.

I may choose to add this test case to the void typedef one from earlier and make it clear, but that's just a personal
preference. I can understand the benefit to have standalone test case.

test/jdk/tools/jextract/test8249300.h line 35:

> 34: typedef void MyVoid;
> 35: EXPORT void func(MyVoid (*f)());
> 36:

Subtle test case relying C syntax without explicit void to make Object[] in function signature. Maybe add a comment to
make that clear.

Not sure if we should make explicit varargs.

-------------

Marked as reviewed by henryjen (Committer).

PR: https://git.openjdk.java.net/panama-foreign/pull/244


More information about the panama-dev mailing list