[foreign-memaccess] RFR: 8249790: Add Addressable abstraction [v2]

Jorn Vernee jvernee at openjdk.java.net
Tue Jul 21 12:01:58 UTC 2020


On Tue, 21 Jul 2020 12:01:36 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> This patch adds a new entity in the Foreign Memory Access API, namely `Addressable`. This is a simple functional
>> interface which is implemented by all the entities which can be mapped onto a `MemoryAddress`. For now, only
>> `MemoryAddress` and `MemorySegment` implements it (but on the foreign-abi branch we will repeat the exercise and add
>> more implementations).
>
> Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix typo in javadoc

Marked as reviewed by jvernee (Committer).

src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/Addressable.java line 1:

> 1: package jdk.incubator.foreign;
> 2:

Copyright header is missing here

src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/Addressable.java line 4:

> 3: /**
> 4:  * Represents a type which is <em>addressable</em>. An addressable type is one which can projected down to
> 5:  * a memory address instance (see {@link #address()}). Examples of addressable types are {@link MemorySegment},

Suggestion:

 * Represents a type which is <em>addressable</em>. An addressable type is one which can be projected down to

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/252


More information about the panama-dev mailing list