[foreign-jextract] RFR: 8249810: Jextract should generate parameter types with Addressable type [v2]

Athijegannathan Sundararajan sundar at openjdk.java.net
Wed Jul 22 10:37:08 UTC 2020


On Wed, 22 Jul 2020 09:59:45 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> This patch tweaks jextract so that all foreign functions wrappers use the new Addressable carrier type, as opposed to
>> the more specific MemoryAddress type. This is useful, as now clients can call such functions with either an address or
>> a segment, w/o any need to call `MemorySegment::address`.  The bulk of the changes are in the TypeTranslator visitor,
>> which now has a parameter which says as to whether an addressable should be used. There are also some changes in the
>> HeaderBuilder class, as we now need to call `Addressable::address` on any incoming addressable parameter (since the
>> method handle generated by the linker expects a `MemoryAddress`).
>
> Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Simplify implementation

Much simpler patch! Looks good.

-------------

Marked as reviewed by sundar (Committer).

PR: https://git.openjdk.java.net/panama-foreign/pull/257


More information about the panama-dev mailing list