[vector] Miscellaneous tests to complete coverage of X-Vector.java
Paul Sandoz
paul.sandoz at oracle.com
Thu Jul 23 17:19:57 UTC 2020
> On Jul 23, 2020, at 10:03 AM, Viswanathan, Sandhya <sandhya.viswanathan at intel.com> wrote:
>
> Hi Paul,
>
> Yes, I did replace the test, by changing OR to ADD the test was generated for Double/Float as well and not just integral types.
> This gave us the lanewise with broadcast long for float/double.
>
> Let me know if you think I should retain the OR as well.
>
If its straightforward to do then probably best to add back the OR test, so as we don’t reduce what we test.
Paul.
> Best Regards,
> Sandhya
>
>
> From: Paul Sandoz <paul.sandoz at oracle.com>
> Sent: Thursday, July 23, 2020 9:44 AM
> To: Viswanathan, Sandhya <sandhya.viswanathan at intel.com>
> Cc: panama-dev at openjdk.java.net' <panama-dev at openjdk.java.net>; Vladimir Ivanov <vladimir.x.ivanov at oracle.com>
> Subject: Re: [vector] Miscellaneous tests to complete coverage of X-Vector.java
>
> Looks good, though something odd happened that I cannot explain.
>
> It looks like a test was replaced:
>
> @Test(dataProvider = "intBinaryOpProvider")
>
> - static void ORInt256VectorTestsBroadcastLongSmokeTest(IntFunction<int[]> fa, IntFunction<int[]> fb) {
> + static void ADDInt256VectorTestsBroadcastLongSmokeTest(IntFunction<int[]> fa, IntFunction<int[]> fb) {
>
> do you know what is going on?
>
> Paul.
>
>
> On Jul 22, 2020, at 10:30 AM, Viswanathan, Sandhya <sandhya.viswanathan at intel.com <mailto:sandhya.viswanathan at intel.com>> wrote:
>
>
> Please find below a webrev which adds miscellaneous tests and attempts to increase the coverage of public methods in X-Vector.java to 100%:
>
> http://cr.openjdk.java.net/~sviswanathan/vectorIntrinsics/TestCoverage/part6/webrev.00/ <http://cr.openjdk.java.net/~sviswanathan/vectorIntrinsics/TestCoverage/part6/webrev.00/>
>
> The smoke tests added are:
> blend with long
> eq
> hashCode
> lanewise with broadcast long for float/double
> lt
> test
> toInt
> toLong
> toString
>
> With this the test coverage of overall Vector API public methods should go up to ~97.5%.
>
> Best Regards,
> Sandhya
More information about the panama-dev
mailing list