[foreign-jextract] RFR: 8250222: ConstantsTest is broken

[Henry Jen]

On Thu, 23 Jul 2020 17:37:28 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

> This patch fixes ConstantsTest, which seems to be in an inconsistent state, especially when it comes to its test for
> missing constants; this test erroneosly looks for fields, not methods, so it always passes (as there are no fields!).
> I've rectified the test, but also I've strengthened it, to make sure that we also check the values of the pointer
> constants (these were not checked before). I also added a test for an array constant (which should be dropped), and
> I've dropped the `UNUSED` constant in `constants_aux.h`, since its use was mostly targeted at some kind of filtering
> mechanism that we no longer have.

Looks good to me.

-------------

Marked as reviewed by henryjen (Committer).

PR: https://git.openjdk.java.net/panama-foreign/pull/263