[foreign-memaccess] RFR: 8249879: Split MemorySegment and MemoryAddress [v3]

[Maurizio Cimadamore]

On Mon, 27 Jul 2020 12:24:36 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Address Paul's review comments.
>
> test/jdk/java/foreign/TestVarHandleCombinators.java line 114:
> 
>> 113:                 for (long j = 0; j < inner_size; j++) {
>> 114:                     vh.set(segment, i * 40 + j * 8, count);
>> 115:                     assertEquals(
> 
> Can this be done with combinators instead of manual offsets like before? Mostly curious about how this use-case changes.

I can change this, for sure, but in real world, such use case would just go through the layout ABI, which does all the
combination you want for free. Are you sure you want me to write what MemoryLayout::varHandle does inside the test?

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/260