[vector] Additional tests for comparison ops to bring the coverage up

[Viswanathan, Sandhya]

Thanks Paul. I removed the INVOC_COUNT loop from smoke tests and pushed the patch.

Best Regards,
Sandhya


From: Paul Sandoz <paul.sandoz at oracle.com>
Sent: Monday, June 08, 2020 5:06 PM
To: Viswanathan, Sandhya <sandhya.viswanathan at intel.com>
Cc: panama-dev <panama-dev at openjdk.java.net>
Subject: Re: [vector] Additional tests for comparison ops to bring the coverage up

Much better :-)

Oh, I forgot to mention in my last reply some of the new smoke tests have the INVOC_COUNT loop. I am guessing you did not intend for that to be there? if so no need to send another web rev if you are gonna remove it.

Paul.


On Jun 8, 2020, at 4:40 PM, Viswanathan, Sandhya <sandhya.viswanathan at intel.com<mailto:sandhya.viswanathan at intel.com>> wrote:

Hi Paul,

Please find the updated webrev at:
http://cr.openjdk.java.net/~sviswanathan/vectorIntrinsics/TestCoverage/part3/webrev.01/

Best Regards,
Sandhya

-----Original Message-----
From: panama-dev <panama-dev-bounces at openjdk.java.net<mailto:panama-dev-bounces at openjdk.java.net>> On Behalf Of Viswanathan, Sandhya
Sent: Monday, June 08, 2020 3:57 PM
To: Paul Sandoz <paul.sandoz at oracle.com<mailto:paul.sandoz at oracle.com>>
Cc: panama-dev <panama-dev at openjdk.java.net<mailto:panama-dev at openjdk.java.net>>
Subject: RE: [vector] Additional tests for comparison ops to bring the coverage up

Yes, I did intend to cast it to $type$. I will update the webrev accordingly.

From: Paul Sandoz <paul.sandoz at oracle.com<mailto:paul.sandoz at oracle.com>>
Sent: Monday, June 08, 2020 3:42 PM
To: Viswanathan, Sandhya <sandhya.viswanathan at intel.com<mailto:sandhya.viswanathan at intel.com>>
Cc: panama-dev <panama-dev at openjdk.java.net<mailto:panama-dev at openjdk.java.net>>; Vladimir Ivanov <vladimir.x.ivanov at oracle.com<mailto:vladimir.x.ivanov at oracle.com>>
Subject: Re: [vector] Additional tests for comparison ops to bring the coverage up

Hi,

Unit-Compare-Broadcast.template
—

 41 #if[!Long]
 42     @Test(dataProvider = "$type$CompareOpProvider")
 43     static void [[TEST]]$vectorteststype$BroadcastLongSmokeTest(IntFunction<$type$[]> fa, IntFunction<$type$[]> fb) {
 44         $type$[] a = fa.apply(SPECIES.length());
 45         $type$[] b = fb.apply(SPECIES.length());
 46
 47         for (int i = 0; i < a.length; i += SPECIES.length()) {
 48             $abstractvectortype$ av = $abstractvectortype$.fromArray(SPECIES, a, i);
 49             VectorMask<$Wideboxtype$> mv = av.compare(VectorOperators.[[TEST]], (long)b[i]);
 50
 51             // Check results as part of computation.
 52             for (int j = 0; j < SPECIES.length(); j++) {
 53                 Assert.assertEquals(mv.laneIsSet(j), a[i + j] [[TEST_OP]] (double)((long)b[i]));

Why the casting to double? Did you intend to cast to $type$?


 54             }
 55         }
 56     }
 57

Paul.



On Jun 8, 2020, at 3:05 PM, Viswanathan, Sandhya <sandhya.viswanathan at intel.com<mailto:sandhya.viswanathan at intel.com><mailto:sandhya.viswanathan at intel.com>> wrote:

Please find below a webrev with additional tests for comparison ops to bring the coverage up:
http://cr.openjdk.java.net/~sviswanathan/vectorIntrinsics/TestCoverage/part3/webrev.00/

Tests added are:
Masked compare with vector
Masked/unmasked compare with scalar (Smoke tests only) Masked/unmasked compare with long (Smoke tests only)

Best Regards,
Sandhya