[foreign-jextract] [Rev 01] RFR: CSupport::getSystemLinker should not be called from internal API points

Maurizio Cimadamore mcimadamore at openjdk.java.net
Tue Jun 9 11:07:57 UTC 2020


On Tue, 9 Jun 2020 10:51:10 GMT, Athijegannathan Sundararajan <sundar at openjdk.org> wrote:

>> Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Reuse `abi` field instead of retrieving ABI again
>
> src/jdk.incubator.jextract/share/classes/jdk/internal/jextract/impl/LayoutUtils.java line 200:
> 
>> 199:             case 32: return Primitive.Kind.Int;
>> 200:             case 64: return SharedUtils.getSystemLinker().name().equals(CSupport.Win64.NAME) ?
>> 201:                     Primitive.Kind.LongLong : Primitive.Kind.Long;
> 
> could use static field "abi" instead?

Fixed in latest iteration

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/198


More information about the panama-dev mailing list