[foreign-abi] RFR: Tweak API and javadoc for VaList
Jorn Vernee
jvernee at openjdk.java.net
Mon Jun 15 15:26:21 UTC 2020
On Mon, 15 Jun 2020 14:59:59 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:
> This is a small patch which fixes some javadoc and API issues in the CSupport.VaList class. Main changes are:
>
> * CSupport::newVaList has been moved as a static factory in VaList (new name is `make`)
> * Valist::toAddress() renamed to just `address`
> * minor javadoc tweaks to better clarify the distinction between underlying C va list and the Java VaList warpper
Marked as reviewed by jvernee (Committer).
src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/CSupport.java line 178:
> 177: * of the underlying C {@code va_list}.
> 178: * @return a new {@code VaList} instance backed a fresh C {@code va_list}.
> 179: */
Suggestion:
* @return a new {@code VaList} instance backed by a fresh C {@code va_list}.
-------------
PR: https://git.openjdk.java.net/panama-foreign/pull/206
More information about the panama-dev
mailing list