[foreign-abi] [Rev 01] RFR: 8247488: Add support for string helpers in CSupport (decoding support)

[Jorn Vernee]

On Tue, 16 Jun 2020 11:53:22 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> This patch add more symmetric support for charset-driven decoding of the contents of a native string.
>> That means we can no longer using a StringBuilder, but, instead, we have to get the byte array and create a `String`
>> out of that using specified `Charset` instance.
>> Implementation-wise, following an offline discussion with Jorn, I've settled for an approach which finds string length,
>> then does a bulk copy to a byte array. Not sure this is going to peform well on small strings. The alternative would
>> have been to use `ByteArrayOutputStream` - but the issue there is that both `write` and `toString` methods there are
>> `synchronized`.  In any case, I think the implementation can be made more efficient later, if we find that to be an
>> issue.
>
> Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix javadoc issues with restricted methods

Marked as reviewed by jvernee (Committer).

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/207