[vector] Miscellaneous tests to complete coverage of X-VectorBits.java plus fix

[Viswanathan, Sandhya]

Hi Paul,

Thanks for your inputs. Please find the updated webrev at:
http://cr.openjdk.java.net/~sviswanathan/vectorIntrinsics/TestCoverage/part5/webrev.01/

I have kept the overloaded names but used one in another. Hope that is ok.
The overloaded names were used in existing rearrange tests as well.

Let me know if I should give different names to these.

Best Regards,
Sandhya


From: Paul Sandoz <paul.sandoz at oracle.com>
Sent: Monday, June 15, 2020 2:54 PM
To: Viswanathan, Sandhya <sandhya.viswanathan at intel.com>
Cc: panama-dev <panama-dev at openjdk.java.net>; Vladimir Ivanov <vladimir.x.ivanov at oracle.com>
Subject: Re: [vector] Miscellaneous tests to complete coverage of X-VectorBits.java plus fix

Looks good.

I stumbled on the two overloaded ADDLong methods:

   3     static long ADDLong($type$[] a, int idx) {
   4         $type$ res = 0;
   5         for (int i = idx; i < (idx + SPECIES.length()); i++) {
   6             res += a[i];
   7         }
   8
   9         return (long)res;
  10     }
  11
  12     static long ADDLong($type$[] a) {
  13         long res = 0;
  14         for (int i = 0; i < a.length; i += SPECIES.length()) {
  15             $type$ tmp = 0;
  16             for (int j = 0; j < SPECIES.length(); j++) {
  17                 tmp += a[i + j];
  18             }
  19             res += (long)tmp;
  20         }
  21
  22         return res;
  23     }


What if you rename the first ADDLongVector, then reuse it in the latter?

Paul.


On Jun 12, 2020, at 6:39 PM, Viswanathan, Sandhya <sandhya.viswanathan at intel.com<mailto:sandhya.viswanathan at intel.com>> wrote:

Please find below a webrev which adds miscellaneous tests and attempts to increase the coverage of X-VectorBits.java to 100%:

http://cr.openjdk.java.net/~sviswanathan/vectorIntrinsics/TestCoverage/part5/webrev.00/

The webrev also fixes an issue found in masked rearrange.

The smoke tests added are:

  1.  Masked rearrange
  2.  selectFrom masked/unmasked
  3.  reduceLanesToLong masked/unmasked
  4.  elementSize
  5.  shape

Best Regards,
Sandhya