[foreign-memaccess] RFR: 8247924: Improve javadoc of Foreign Memory Access API (part two) [v2]
Maurizio Cimadamore
mcimadamore at openjdk.java.net
Fri Jun 19 14:03:17 UTC 2020
On Fri, 19 Jun 2020 13:27:38 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:
>> Maurizio Cimadamore has updated the pull request with a new target base due to a merge or a rebase. The incremental
>> webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits
>> since the last revision:
>> - Update src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/MemoryLayout.java
>>
>> Co-authored-by: Jorn Vernee <JornVernee at users.noreply.github.com>
>> - Update src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/package-info.java
>>
>> Co-authored-by: Jorn Vernee <JornVernee at users.noreply.github.com>
>> - Merge branch 'foreign-memaccess' into foreign-memaccess-doc2
>> - Misc javadoc fixes
>> - Fix javadoc for close()
>> - Clarify javadoc w.r.t close and aliasing of existing memory sources.
>
> src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/MemoryLayout.java line 128:
>
>> 127: * For instance, given the {@code taggedValues} layout instance constructed as above, we can obtain the offset,
>> 128: * in bits, of the <em>first</em> member layout named <code>value</code>, as follows:
>> 129: * <blockquote><pre>{@code
>
> Shouldn't it say 'the second member layout'? ('kind' is the first)
first in the sequence
-------------
PR: https://git.openjdk.java.net/panama-foreign/pull/211
More information about the panama-dev
mailing list