[foreign-memaccess] Simplifying memory access var handles

[Maurizio Cimadamore]

On 23/06/2020 23:40, Paul Sandoz wrote:
>
>> On Jun 23, 2020, at 10:58 AM, Maurizio Cimadamore <maurizio.cimadamore at oracle.com> wrote:
>>
>> Here's a branch with an initial stab:
>>
>> https://github.com/mcimadamore/panama-foreign/tree/simpler-memory-VH
>>
>> Lot less code,
> A very encouraging sign.
>
>
>> all benchamarks run as expected.
>>
>> I had to add a minor tweak to retain the existing shortcircuiting of the alignment check of the "offset" portion of a memory access in case the VH has been constructed using a layout (in which case alignment checks on offsets are enforced eagerly, on layout construction/VH derivation).
>>
> Yeah, it looks a little odd, but its never exposed publicly..

Note that this will go away once C2 can hoist alignment checks out of 
loops (this is mostly to workaround that performance pothole)

Maurizio

>
> Paul.
>
>> Other than that pretty trivial.
>>
>> Maurizio