[foreign-jextract] RFR: 8240300: jextract produces non compilable code with repeated declarations

Athijegannathan Sundararajan sundar at openjdk.java.net
Tue Mar 3 03:55:53 UTC 2020


On Mon, 2 Mar 2020 18:41:11 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Filtering repeated global variables and functions in code generator (added necessary hashCode, equals for decls, types)
>
> Looks good - thanks for adding equals/hashcode to types and declaration. I guess we should add them to the top interfaces as well (so that we can document that these things can be compared with equals()) ?

> Looks good - thanks for adding equals/hashcode to types and declaration. I guess we should add them to the top interfaces as well (so that we can document that these things can be compared with equals()) ?

Yes. I agree. I'll add equals and hashCode to Declaration and Type as suggested.

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/37


More information about the panama-dev mailing list