[foreign-jextract] [Rev 02] RFR: 8240300: jextract produces non compilable code with repeated declarations

Henry Jen henryjen at openjdk.java.net
Tue Mar 3 17:27:56 UTC 2020


On Tue, 3 Mar 2020 09:14:01 GMT, Athijegannathan Sundararajan <sundar at openjdk.org> wrote:

>> Filtering repeated global variables and functions in code generator (added necessary hashCode, equals for decls, types)
>
> The pull request has been updated with 1 additional commit.

Looks good in general.

Type.Delegate is tricky, especially with multiple delegations. In current implementation we requires the order to be the same if I read that correctly. I feels like that atomic signed int and signed atomic int should be considered equal?

-------------

Marked as reviewed by henryjen (Committer).

PR: https://git.openjdk.java.net/panama-foreign/pull/37


More information about the panama-dev mailing list