[vector] Fix reduce_add2F/reduce_add2D for incorrect associativity

Yang Zhang Yang.Zhang at arm.com
Thu Mar 5 03:53:41 UTC 2020


Looks good to me.

Regards
Yang

-----Original Message-----
From: panama-dev <panama-dev-bounces at openjdk.java.net> On Behalf Of Qi Feng
Sent: Wednesday, March 4, 2020 3:03 PM
To: panama-dev at openjdk.java.net
Cc: nd <nd at arm.com>
Subject: [vector] Fix reduce_add2F/reduce_add2D for incorrect associativity

Hi,

Please help me review this patch.

Webrev: http://cr.openjdk.java.net/~yzhang/vectorapi/vectorapi.fadd/webrev.00/

The implementation of these two instructs on AArch64 accumulate it's arguments in the wrong order, since the addition of floating point values doesn't obey associative law.

Thanks,
Qi



More information about the panama-dev mailing list