[foreign-jextract] [Rev 01] RFR: Improve jextract error reporting

Jorn Vernee jvernee at openjdk.java.net
Fri Mar 6 11:00:34 UTC 2020


On Fri, 6 Mar 2020 02:50:16 GMT, Athijegannathan Sundararajan <sundar at openjdk.org> wrote:

>> Looks good, my only concern is the disable clang crash recovery default was disabled but now default to enable.
>> 
>> The past experience is that crash recovery cause JVM crash from time to time, so unless we are certain that situation changes and should be default to enable, perhaps we should just default to disable as before.
>
>> Looks good, my only concern is the disable clang crash recovery default was disabled but now default to enable.
>> 
>> The past experience is that crash recovery cause JVM crash from time to time, so unless we are certain that situation changes and should be default to enable, perhaps we should just default to disable as before.
> 
> I agree with Henry. It's better to restore the default but make it configurable via system property. Having different defaults on different platforms would be confusing to the user. Because it is configurable, we can try the config for debugging on any platform.

I've uploaded another revision where I've change the default of crash recovery back to disabled, but kept the property.

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/40


More information about the panama-dev mailing list