[foreign-abi] [Rev 01] RFR: 8241148: need a way to create MemorySegment with contents from java String and a way to read a C char* as java String

[Athijegannathan Sundararajan]

On Thu, 19 Mar 2020 11:00:05 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Athijegannathan Sundararajan has updated the pull request incrementally with one additional commit since the last
>> revision:
>>   * renamed makeNativeString as toCString
>>   * added Charset accepting variant for toCString
>>   * fixed test to compare PATH value with System.getenv("PATH")
>
> Added comment on test

> That said, let's not focus too much on the fact that ForeignUnsafe is outside the API, as we have another change we're
> working on which will bring ForeignUnsafe inside the official API (guarded by some flag), with probably a different
> name.

Hi Ty,
As Maurizio mentioned, we have a plan to bring ForeignUnsafe inside the official API. So for the current change, let's
keep these string utils in ForeignUnsafe.

> Added comment on test

I'll fix the test to iterate through all System env. vars.

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/55