[foreign-memaccess] [Rev 03] RFR: JDK-8241154: Clarify the role of MemorySegments

Maurizio Cimadamore mcimadamore at openjdk.java.net
Mon Mar 23 19:13:46 UTC 2020


On Mon, 23 Mar 2020 14:18:47 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> Maurizio Cimadamore has updated the pull request incrementally with four additional commits since the last revision:
>> 
>>  - Update src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/MemorySegment.java
>>    
>>    Co-Authored-By: Jorn Vernee <JornVernee at users.noreply.github.com>
>>  - Update src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/MemorySegment.java
>>    
>>    Co-Authored-By: Jorn Vernee <JornVernee at users.noreply.github.com>
>>  - Update src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/MemorySegment.java
>>    
>>    Co-Authored-By: Jorn Vernee <JornVernee at users.noreply.github.com>
>>  - Fix javadoc missing @param
>
> Looks good. Left some minor inline comments

Uploaded new version which addresses review comments and adds some extra API points to obtain raw address/base object
associated with memory source (this makes ForeignUnsafe redundant). Javadoc available here:

http://cr.openjdk.java.net/~mcimadamore/panama/8241154_javadoc_v2/javadoc/jdk/incubator/foreign/package-summary.html

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/54


More information about the panama-dev mailing list