[foreign-abi] [Rev 01] RFR: 8241504: Expose MemoryLayout annotations/attributes in the public API
Jorn Vernee
jvernee at openjdk.java.net
Tue Mar 24 16:25:39 UTC 2020
On Tue, 24 Mar 2020 14:29:24 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Addressed review comments + added basic tests
>
> Couple of suggestions, the rest looks really solid.
I've also added some very basic tests of the new methods, mostly to sort of document the expectations w.r.t. how NAME
is just another attribute, plus how using the attribute(String,Class) overload filters the optional with an instanceof
check as opposed to simply casting (and potentially failing that cast with CCE).
-------------
PR: https://git.openjdk.java.net/panama-foreign/pull/64
More information about the panama-dev
mailing list