[foreign-abi] [Rev 02] RFR: 8241504: Expose MemoryLayout annotations/attributes in the public API

Jorn Vernee jvernee at openjdk.java.net
Tue Mar 24 17:26:55 UTC 2020


> Hi,
> 
> This PR exposed MemoryLayout attributes in the public API.
> 
> A summary of the changes:
> - Renamed annotation -> attribute everywhere to avoid confusion with Java language annotations
> - Made sure that annotations were being serialized as part of a MemoryLayout's ConstantDesc, as well as the alignment
>   which was previously left out. (The latter also meant changing PaddingLayout::hasNaturalAlignment to always return
>   `true`, so serializing alignment is skipped for padding). Removed special casing for the abiType attribute. This can
>   now instead be handled through the generic attribute mechanism.
> 
> Thanks,
> Jorn

Jorn Vernee has updated the pull request incrementally with one additional commit since the last revision:

  Update src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/SystemABI.java
  
  Co-Authored-By: Maurizio Cimadamore <54672762+mcimadamore at users.noreply.github.com>

-------------

Changes:
  - all: https://git.openjdk.java.net/panama-foreign/pull/64/files
  - new: https://git.openjdk.java.net/panama-foreign/pull/64/files/2d58b86d..380a1b04

Webrevs:
 - full: https://webrevs.openjdk.java.net/panama-foreign/64/webrev.02
 - incr: https://webrevs.openjdk.java.net/panama-foreign/64/webrev.01-02

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/panama-foreign/pull/64.diff
  Fetch: git fetch https://git.openjdk.java.net/panama-foreign pull/64/head:pull/64

PR: https://git.openjdk.java.net/panama-foreign/pull/64


More information about the panama-dev mailing list