[foreign-memaccess] [Rev 03] RFR: JDK-8241154: Clarify the role of MemorySegments
Jorn Vernee
jorn.vernee at oracle.com
Tue Mar 24 17:29:18 UTC 2020
I agree with Paul.
Would be nice to split out the registerCleaner part and handle that in a
separate PR.
Jorn
On 24/03/2020 13:03, Maurizio Cimadamore wrote:
> On Mon, 23 Mar 2020 19:04:47 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:
>
>>> Looks good. Left some minor inline comments
>> Uploaded new version which addresses review comments and adds some extra API points to obtain raw address/base object
>> associated with memory source (this makes ForeignUnsafe redundant). Javadoc available here:
>> http://cr.openjdk.java.net/~mcimadamore/panama/8241154_javadoc_v2/javadoc/jdk/incubator/foreign/package-summary.html
> Just realized that for this to work properly I need to add reachabilty fences in all the var handle code (at least,
> possibly AB invokers need to do the same). Should I do it as part of this effort, or should I split and deal with
> registerCleaner later?
>
> -------------
>
> PR: https://git.openjdk.java.net/panama-foreign/pull/54
More information about the panama-dev
mailing list