[vector-unstable] RFR: Remove SVML stubs and JVM support for them

Viswanathan, Sandhya sandhya.viswanathan at intel.com
Tue Mar 24 22:05:53 UTC 2020


Hi Vladimir,

I have been manually doing the merge from vectorIntrinisics to vector-unstable branch as and when needed.
Let us wait till your "JVM interface refactor" patch is checked in vectorIntrinsics and merged to vector-unstable before pushing "SVML removal" to vector-ustable.
I will run the "JVM interface refactor" through our tests today.

Best Regards,
Sandhya

-----Original Message-----
From: Vladimir Ivanov <vladimir.x.ivanov at oracle.com> 
Sent: Tuesday, March 24, 2020 2:53 PM
To: Viswanathan, Sandhya <sandhya.viswanathan at intel.com>; panama-dev <panama-dev at openjdk.java.net>
Subject: Re: [vector-unstable] RFR: Remove SVML stubs and JVM support for them

Thanks, Sandhya.

I'm still uncertain how vectorIntrinsics and vector-unstable branches interact right now.

It looks like vector-unstable is regularly synced with vectorIntrinsics, so we would like to minimize the divergence to simplify merging.

On the other hand, stabilization will diverge the code.

So, as I see it, at some point we need to stop regular merges and switch to jdk/jdk merges to simplify stabilization work.

I'm fine with delaying SVML removal until all planned patches are there. 
Let me know when it is a good time to push it.

Once the implementation is integrated into the mainline, we can sync it with vectorIntrinsics.

Best regards,
Vladimir Ivanov

On 25.03.2020 00:41, Viswanathan, Sandhya wrote:
> Hi Vladimir,
> 
> The patch looks good to me. Thanks a lot for taking care of this.
> 
> Best Regards,
> Sandhya
> 
> -----Original Message-----
> From: panama-dev <panama-dev-bounces at openjdk.java.net> On Behalf Of 
> Vladimir Ivanov
> Sent: Tuesday, March 24, 2020 8:08 AM
> To: panama-dev <panama-dev at openjdk.java.net>
> Subject: [vector-unstable] RFR: Remove SVML stubs and JVM support for 
> them
> 
> http://cr.openjdk.java.net/~vlivanov/panama/vector-unstable/remove_svm
> l/webrev.00/
> 
> Considering SVML stubs aren't going to make it into the first version, I propose to remove relevant code from stabilization branch.
> 
> The patch removes JVM support for SVML stubs (along with vector call
> support) and migrates API implementation to scalar version.
> 
> The webrev doesn't include the stubs, but I plan to remove them as well [1].
> 
> Testing: jdk/incubator/vector tests all pass.
> 
> Best regards,
> Vladimir Ivanov
> 
> [1]
> R src/hotspot/os_cpu/linux_x86/svml_d_acos_linux_x86.S
> R src/hotspot/os_cpu/linux_x86/svml_d_asin_linux_x86.S
> R src/hotspot/os_cpu/linux_x86/svml_d_atan2_linux_x86.S
> R src/hotspot/os_cpu/linux_x86/svml_d_atan_linux_x86.S
> R src/hotspot/os_cpu/linux_x86/svml_d_cbrt_linux_x86.S
> R src/hotspot/os_cpu/linux_x86/svml_d_cos_linux_x86.S
> R src/hotspot/os_cpu/linux_x86/svml_d_cosh_linux_x86.S
> R src/hotspot/os_cpu/linux_x86/svml_d_exp_linux_x86.S
> R src/hotspot/os_cpu/linux_x86/svml_d_expm1_linux_x86.S
> R src/hotspot/os_cpu/linux_x86/svml_d_hypot_linux_x86.S
> R src/hotspot/os_cpu/linux_x86/svml_d_log10_linux_x86.S
> R src/hotspot/os_cpu/linux_x86/svml_d_log1p_linux_x86.S
> R src/hotspot/os_cpu/linux_x86/svml_d_log_linux_x86.S
> R src/hotspot/os_cpu/linux_x86/svml_d_pow_linux_x86.S
> R src/hotspot/os_cpu/linux_x86/svml_d_sin_linux_x86.S
> R src/hotspot/os_cpu/linux_x86/svml_d_sinh_linux_x86.S
> R src/hotspot/os_cpu/linux_x86/svml_d_tan_linux_x86.S
> R src/hotspot/os_cpu/linux_x86/svml_d_tanh_linux_x86.S
> R src/hotspot/os_cpu/linux_x86/svml_s_acos_linux_x86.S
> R src/hotspot/os_cpu/linux_x86/svml_s_asin_linux_x86.S
> R src/hotspot/os_cpu/linux_x86/svml_s_atan2_linux_x86.S
> R src/hotspot/os_cpu/linux_x86/svml_s_atan_linux_x86.S
> R src/hotspot/os_cpu/linux_x86/svml_s_cbrt_linux_x86.S
> R src/hotspot/os_cpu/linux_x86/svml_s_cos_linux_x86.S
> R src/hotspot/os_cpu/linux_x86/svml_s_cosh_linux_x86.S
> R src/hotspot/os_cpu/linux_x86/svml_s_exp_linux_x86.S
> R src/hotspot/os_cpu/linux_x86/svml_s_expm1_linux_x86.S
> R src/hotspot/os_cpu/linux_x86/svml_s_hypot_linux_x86.S
> R src/hotspot/os_cpu/linux_x86/svml_s_log10_linux_x86.S
> R src/hotspot/os_cpu/linux_x86/svml_s_log1p_linux_x86.S
> R src/hotspot/os_cpu/linux_x86/svml_s_log_linux_x86.S
> R src/hotspot/os_cpu/linux_x86/svml_s_pow_linux_x86.S
> R src/hotspot/os_cpu/linux_x86/svml_s_sin_linux_x86.S
> R src/hotspot/os_cpu/linux_x86/svml_s_sinh_linux_x86.S
> R src/hotspot/os_cpu/linux_x86/svml_s_tan_linux_x86.S
> R src/hotspot/os_cpu/linux_x86/svml_s_tanh_linux_x86.S
> R src/hotspot/os_cpu/windows_x86/svml_d_acos_windows_x86.s
> R src/hotspot/os_cpu/windows_x86/svml_d_asin_windows_x86.s
> R src/hotspot/os_cpu/windows_x86/svml_d_atan2_windows_x86.s
> R src/hotspot/os_cpu/windows_x86/svml_d_atan_windows_x86.s
> R src/hotspot/os_cpu/windows_x86/svml_d_cbrt_windows_x86.s
> R src/hotspot/os_cpu/windows_x86/svml_d_cos_windows_x86.s
> R src/hotspot/os_cpu/windows_x86/svml_d_cosh_windows_x86.s
> R src/hotspot/os_cpu/windows_x86/svml_d_exp_windows_x86.s
> R src/hotspot/os_cpu/windows_x86/svml_d_expm1_windows_x86.s
> R src/hotspot/os_cpu/windows_x86/svml_d_hypot_windows_x86.s
> R src/hotspot/os_cpu/windows_x86/svml_d_log10_windows_x86.s
> R src/hotspot/os_cpu/windows_x86/svml_d_log1p_windows_x86.s
> R src/hotspot/os_cpu/windows_x86/svml_d_log_windows_x86.s
> R src/hotspot/os_cpu/windows_x86/svml_d_pow_windows_x86.s
> R src/hotspot/os_cpu/windows_x86/svml_d_sin_windows_x86.s
> R src/hotspot/os_cpu/windows_x86/svml_d_sinh_windows_x86.s
> R src/hotspot/os_cpu/windows_x86/svml_d_tan_windows_x86.s
> R src/hotspot/os_cpu/windows_x86/svml_d_tanh_windows_x86.s
> R src/hotspot/os_cpu/windows_x86/svml_s_acos_windows_x86.s
> R src/hotspot/os_cpu/windows_x86/svml_s_asin_windows_x86.s
> R src/hotspot/os_cpu/windows_x86/svml_s_atan2_windows_x86.s
> R src/hotspot/os_cpu/windows_x86/svml_s_atan_windows_x86.s
> R src/hotspot/os_cpu/windows_x86/svml_s_cbrt_windows_x86.s
> R src/hotspot/os_cpu/windows_x86/svml_s_cos_windows_x86.s
> R src/hotspot/os_cpu/windows_x86/svml_s_cosh_windows_x86.s
> R src/hotspot/os_cpu/windows_x86/svml_s_exp_windows_x86.s
> R src/hotspot/os_cpu/windows_x86/svml_s_expm1_windows_x86.s
> R src/hotspot/os_cpu/windows_x86/svml_s_hypot_windows_x86.s
> R src/hotspot/os_cpu/windows_x86/svml_s_log10_windows_x86.s
> R src/hotspot/os_cpu/windows_x86/svml_s_log1p_windows_x86.s
> R src/hotspot/os_cpu/windows_x86/svml_s_log_windows_x86.s
> R src/hotspot/os_cpu/windows_x86/svml_s_pow_windows_x86.s
> R src/hotspot/os_cpu/windows_x86/svml_s_sin_windows_x86.s
> R src/hotspot/os_cpu/windows_x86/svml_s_sinh_windows_x86.s
> R src/hotspot/os_cpu/windows_x86/svml_s_tan_windows_x86.s
> R src/hotspot/os_cpu/windows_x86/svml_s_tanh_windows_x86.s
> 


More information about the panama-dev mailing list