[vectorIntrinsics] RFR: Cleanup code for SVML support

Vladimir Ivanov vladimir.x.ivanov at oracle.com
Thu Mar 26 09:36:35 UTC 2020


Thanks, Sandhya.

> Only one comment:
> 
> In stubGenerator_x86_64.cpp, the else at line 6966 should be removed.
> 6966     } else

Good catch! I'll make the adjustment before the push.

Best regards,
Vladimir Ivanov

> -----Original Message-----
> From: panama-dev <panama-dev-bounces at openjdk.java.net> On Behalf Of Vladimir Ivanov
> Sent: Wednesday, March 25, 2020 9:41 AM
> To: panama-dev <panama-dev at openjdk.java.net>
> Subject: [vectorIntrinsics] RFR: Cleanup code for SVML support
> 
> http://cr.openjdk.java.net/~vlivanov/panama/vector/cleanup.svml/webrev.00/
> 
> Considering EnableVectorSupport is turned off by default, SVML entry points should be either lazily or unconditionally initialized.
> Considering it's just caching entry point addresses I chose the latter.
> 
> Also, some cleanups (new flag to control usage of SVML stubs, renamings, etc).
> 
> Testing: jdk/incubator/vector tests
> 
> Thanks!
> 
> Best regards,
> Vladimir Ivanov
> 


More information about the panama-dev mailing list