[foreign-abi] RFR: 8241712: AArch64: TestDowncall fails with IllegalArgumentException: No ABI attribute present

[Jorn Vernee]

On Fri, 27 Mar 2020 07:29:36 GMT, Nick Gasson <ngasson at openjdk.org> wrote:

> Tests cases where the structure has an initial floating point element followed by padding fail with this exception. The
> padding element doesn't have the NATIVE_TYPE attribute.
>   test TestDowncall.testDowncall("f0_V_S_FD", VOID, [STRUCT], [FLOAT, DOUBLE]): failure
>   java.lang.IllegalArgumentException: No ABI attribute present
>           at jdk.incubator.foreign/jdk.incubator.foreign.SystemABI$Type.lambda$fromLayout$0(SystemABI.java:195)
>           at java.base/java.util.Optional.orElseThrow(Optional.java:401)
>           at jdk.incubator.foreign/jdk.incubator.foreign.SystemABI$Type.fromLayout(SystemABI.java:195)
>           at
>           jdk.incubator.foreign/jdk.internal.foreign.abi.aarch64.CallArranger.isHomogeneousFloatAggregate(CallArranger.java:207)
>           at jdk.incubator.foreign/jdk.internal.foreign.abi.aarch64.CallArranger.classifyStructType(CallArranger.java:220)

Looks good to me. Thanks for fixing!

-------------

Marked as reviewed by jvernee (Committer).

PR: https://git.openjdk.java.net/panama-foreign/pull/70