[foreign-abi] RFR: 8241712: AArch64: TestDowncall fails with IllegalArgumentException: No ABI attribute present

[Jorn Vernee]

On Fri, 27 Mar 2020 10:31:53 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

> 
> 
> > Looks good to me. Thanks for fixing!
> 
> I wonder if we have same problem on Linux...

The tests are currently passing, and looking at the code there is one case where trying to look up the ABI type of
padding could cause an exception, but an exception would be thrown for padding any ways:

private static List<ArgumentClassImpl> classifyValueType(ValueLayout type) {
    ArrayList<ArgumentClassImpl> classes = new ArrayList<>();
    ArgumentClassImpl clazz = SysVx64ABI.argumentClassFor(SystemABI.Type.fromLayout(type));
    if (clazz == null) {
        //padding not allowed here
        throw new IllegalStateException("Unexpected value layout: could not determine ABI class");
    }
...
So, I think we're good.

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/70