[foreign-memaccess] RFR: JDK-8241866:Add API to reshape sequence layouts

Jorn Vernee jvernee at openjdk.java.net
Tue Mar 31 07:59:05 UTC 2020


On Mon, 30 Mar 2020 17:34:40 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

> https://docs.scipy.org/doc/numpy/reference/generated/numpy.reshape.html
> 
> As in Python, clients can use _at most_ one `-1` dimension value, and that dimension value will be inferred by
> remaining dimensions.
> The changes also add the `flatten` method, which does the opposite - e.g. take a sequence layout, whose element layout
> could be other nested sequence layouts and flatten everything into an outermost sequence layout (where element count is
> adjusted as needed).  These routines are fairly general and helpful and I found myself in need for something similar
> when writing code doing parallel processing of memory segments, but there are many other possible use cases.

Looks good. One minor comment.

test/jdk/java/foreign/TestReshape.java line 8:

> 7:  * published by the Free Software Foundation.  Oracle designates this
> 8:  * particular file as subject to the "Classpath" exception as provided
> 9:  * by Oracle in the LICENSE file that accompanied this code.

Wrong copyright header

-------------

Marked as reviewed by jvernee (Committer).

PR: https://git.openjdk.java.net/panama-foreign/pull/75


More information about the panama-dev mailing list