[foreign-memaccess] [Rev 01] RFR: JDK-8241866:Add API to reshape sequence layouts

[Paul Sandoz]

On Tue, 31 Mar 2020 14:24:48 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> https://docs.scipy.org/doc/numpy/reference/generated/numpy.reshape.html
>> 
>> As in Python, clients can use _at most_ one `-1` dimension value, and that dimension value will be inferred by
>> remaining dimensions.
>> The changes also add the `flatten` method, which does the opposite - e.g. take a sequence layout, whose element layout
>> could be other nested sequence layouts and flatten everything into an outermost sequence layout (where element count is
>> adjusted as needed).  These routines are fairly general and helpful and I found myself in need for something similar
>> when writing code doing parallel processing of memory segments, but there are many other possible use cases.
>
> Maurizio Cimadamore has updated the pull request with a new target base due to a merge or a rebase. The incremental
> webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits
> since the last revision:
>  - Addressed review comments
>  - Fix whitespaces
>  - Forgot to add file
>  - Add SequenceLayout::reshape/flatten

Marked as reviewed by psandoz (Committer).

src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/SequenceLayout.java line 136:

> 135:      * @param elementCounts an array of element counts, of which at most one can be {@code -1}.
> 136:      * @return a new sequence layout where element element layouts in the flattened projection of this
> 137:      * sequence layout (see {@link #flatten()}) are re-arranged into one or more nested sequence layouts.

s/element element/element

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/75