[vector] Fix build failures

Paul Sandoz paul.sandoz at oracle.com
Thu May 7 15:37:33 UTC 2020


Hi Qi,

Thanks for fixing the bad merge in aarch64.ad and fixing the signature in sharedRuntime_zero.cpp.

The change to library_call.cpp I am less certain about as prior to your change it is identical to that in jdk/jdk:

  http://hg.openjdk.java.net/jdk/jdk/file/tip/src/hotspot/share/opto/library_call.cpp#l2203

and the history shows those declarations have not changed.

Recently the recommended version of gcc was changed to 9.2.0 (from 8.3.0):

  https://bugs.openjdk.java.net/browse/JDK-8241721 <https://bugs.openjdk.java.net/browse/JDK-8241721>
  https://hg.openjdk.java.net/jdk/jdk/rev/f2a0b262efea

Paul.

> On May 6, 2020, at 7:20 PM, Qi Feng <Qi.Feng at arm.com> wrote:
> 
> Hi,
> 
> This patch fixes zero variant build failure. The failure is caused by
> signature mismatch of function SharedRuntime::vector_calling_convention.
> 
> Another failure that occurs when building with gcc8 is fixed. The error
> message in this case is:
> 
>  builds/panama/temp2/hotspot/variant-server/libjvm/objs/vectorIntrinsics.o: In function `LibraryCallKit::inline_vector_mem_operation(bool)':
>  repos/panama/src/hotspot/share/opto/vectorIntrinsics.cpp:580: undefined reference to `LibraryCallKit::make_unsafe_address(Node*&, Node*, unsigned long, BasicType, bool)'
>  builds/panama/temp2/hotspot/variant-server/libjvm/objs/vectorIntrinsics.o: In function `LibraryCallKit::inline_vector_gather_scatter(bool)':
>  repos/panama/src/hotspot/share/opto/vectorIntrinsics.cpp:742: undefined reference to `LibraryCallKit::make_unsafe_address(Node*&, Node*, unsigned long, BasicType, bool)'
>  collect2: error: ld returned 1 exit status
>  lib/CompileJvm.gmk:181: recipe for target '/home/qifen01/builds/panama/temp2/support/modules_libs/java.base/server/libjvm.so' failed
>  make[3]: *** [/home/qifen01/builds/panama/temp2/support/modules_libs/java.base/server/libjvm.so] Error 1
> 
> Still another build failure on aarch64, which is caused by the
> duplication of instruct vmul8B/vmul16B and introduced in a recent
> merge, is fixed as well.
> 
> Webrev: http://cr.openjdk.java.net/~qfeng/panama/vectorapi/zero_build/webrev.00/
> 
> Thanks,
> Qi
> 



More information about the panama-dev mailing list