[vector] Replace IllegalArgumentE with UnsupportedOE for zero arg methods

Viswanathan, Sandhya sandhya.viswanathan at intel.com
Thu May 7 18:11:14 UTC 2020


Hi Paul,

Changes look good. Only one question below:

For ByteVector.java and ShortVector.java, the method viewAsFloatingLanes is throwing AssertionError and not UnsupportedOperationException:

     viewAsFloatingLanes() {
         LaneType flt = LaneType.SHORT.asFloating();
         throw new AssertionError();  // should already throw IAE
     }

Best Regards,
Sandhya

-----Original Message-----
From: panama-dev <panama-dev-bounces at openjdk.java.net> On Behalf Of Paul Sandoz
Sent: Wednesday, May 06, 2020 5:22 PM
To: panama-dev at openjdk.java.net' <panama-dev at openjdk.java.net>
Subject: [vector] Replace IllegalArgumentE with UnsupportedOE for zero arg methods

Hi,

Please review the following change replacing IllegalArgumentException with UnsupportedOperationException for some methods that accept zero args:

  http://cr.openjdk.java.net/~psandoz/panama/vector-ise-to-uoe/webrev/ <http://cr.openjdk.java.net/~psandoz/panama/vector-ise-to-uoe/webrev/>

This change is in response to reviews in preparation for integration into jdk/jdk.

Paul.


More information about the panama-dev mailing list