[foreign-memaccess] RFR: Add MemorySegment::fill

[Jim Laskey]

On Wed, 13 May 2020 13:35:03 GMT, Chris Hegarty <chegar at openjdk.org> wrote:

> Hi,
> 
> As part of feedback on the Foreign Memory API (when experimenting with
> its usage internally in the JDK), a small number of potential usability
> enhancements could be made to the API. This is the second such.
> 
> This change proposes to add a new method:
>   MemorySegment::fill
> 
> Which fills a value into the given memory segment. Fill can be useful to
> initialize or reset the memory of a segment, similar(ish) to memset.
> 
> There are obviously different ways to provide such functionality, e.g.
> accepting a fill value with a bit width greater than 8 bits, but on
> balance this single method will likely satisfy the majority of simple
> use-cases. Other more advanced initialization scenarios would likely be
> served better from an interaction with the Vector API, or some such.

Marked as reviewed by JimLaskey at github.com (no known OpenJDK username).

test/jdk/java/foreign/TestSegments.java line 257:

> 256:     @Test(expectedExceptions = NullPointerException.class)
> 257:     public void testFillWithNull() {
> 258:         MemorySegment.fill(null, (byte) 0xFF);

Not "fill with null" but "fill null".

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/161