[foreign-jextract] [Rev 01] RFR: 8244959: Jextract's VarargsInvoker fails to link functions when passing integer types other than long
Maurizio Cimadamore
mcimadamore at openjdk.java.net
Thu May 14 21:38:07 UTC 2020
On Thu, 14 May 2020 19:08:43 GMT, Henry Jen <henryjen at openjdk.org> wrote:
>> This PR makes sure VarargsInvoker use exact size match layout for carrier type for varargs parameters.
>>
>> Use sprintf as the test case, tested on Mac OS X, need verification on Windows to verify the needed share library is
>> loaded by JVM.
>
> Henry Jen has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev
> excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since
> the last revision:
> - 8244959: Jextract's VarargsInvoker fails to link functions when passing integer types other than long
> - Merge branch 'foreign-jextract' of https://github.com/openjdk/panama-foreign into 8244959
> - 8244959: Jextract's VarargsInvoker fails to link functions when passing integer types other than long
Good work. I suspect that if we ported the StdLibTest to work on jextracted functions, we could probably stress test
the varargs support quite a bit (as well as other things). Perhaps might be worth investing some time on that
separately.
-------------
Marked as reviewed by mcimadamore (Committer).
PR: https://git.openjdk.java.net/panama-foreign/pull/164
More information about the panama-dev
mailing list