[foreign-memaccess] [Rev 01] RFR: Move "owner" field and thread-confinement checks to MemoryScope
Peter Levart
plevart at openjdk.java.net
Fri May 15 12:20:03 UTC 2020
On Fri, 15 May 2020 11:50:13 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:
>> Peter Levart has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Improvements to MemoryScope code considering Maurizio's comments.
>
> src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/MemoryScope.java line 259:
>
>> 258: void close() {
>> 259: justClose();
>> 260: if (cleanupAction != null) {
>
> This is exactly what I had in mind - I think the code is cleaner. Perhaps rename `justClose` to `doClose` (and make
> `doClose` private) - but that's minor - I'll leave that up to you.
I think justClose() tells more that doClose() and private it is.
-------------
PR: https://git.openjdk.java.net/panama-foreign/pull/167
More information about the panama-dev
mailing list