[foreign-abi] [Rev 01] RFR: Rename SystemABI to ForeignLinker, and move C support to a separate class.
Jorn Vernee
jvernee at openjdk.java.net
Mon May 18 14:08:55 UTC 2020
On Mon, 18 May 2020 14:04:07 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:
>> Marked as reviewed by mcimadamore (Committer).
>
>>
>>
>> Renaming looks good - is there a reason as to why the Cstring was left in place as a test util? If you prefer to
>> address as a followup that's ok with me.
>
> Ah, you were talking about the test util. I was thinking about the CString class that is generated by jextract :)
>
> I'd rather address that separately, since I think I have some other ideas w.r.t. Cstring I'd also like to bring up.
I'll do a rebase and re-run the tests before integrating, just to be sure.
-------------
PR: https://git.openjdk.java.net/panama-foreign/pull/174
More information about the panama-dev
mailing list