[foreign-memaccess] [Rev 02] RFR: Add MemorySegment::mismatch

Chris Hegarty chegar at openjdk.java.net
Thu May 21 08:07:29 UTC 2020


On Wed, 20 May 2020 23:02:09 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Chris Hegarty has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev
>> excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since
>> the last revision:
>>  - Integrate Paul's review comment
>>  - Merge remote-tracking branch 'origin/foreign-memaccess' into mismatch
>>  - Move implementation into vectorizedMismatchLarge, and address other review comments.
>>  - Initial mismatch implementation
>
> Looks good

The proposed `MemorySegment::mismatch` spec wording is aligned with similar in the buffer classes and elsewhere. If it
needs clarification then we should probably do so consistently. As @mcimadamore said, "that's something for another
day" ;-)

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/180


More information about the panama-dev mailing list